Hi @winnettjohnston, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

The email address that was used in the commit has been added to my profile.

Hi @winnettjohnston, just so I'm sure I understand the use case here, are you defining REPO_DIR in your defaults file and letting that populate the variable? There's no spot in the module that sets the REPO_DIR environment variable.

(Note that this will break 5.x when you pass path. options that are empty, but there are other cases aside from this one so we'll need to fix them all at the same time)

Hi @tylerjl , the case here was to solve the problem that arose out of a need to enable snapshotting /backup. Currently, i am storing the REPO_DIR in the /etc/sysconfig/elasticearch-${instance} (along with other settings). I am running on 2.2.1 (eww) so i haven't tested this on 5. yet.

Thanks @winnettjohnston, makes sense. Eventually We'll probably need to proactively remove this and other environment variables that are empty by default to permit for 5.x compatibility, so out of curiosity, is there any reason you can't use the path.repo setting in your elasticsearch.yml?

Hi there,

Firstly, thank you for taking the time to contribute, and apologies for the radio silence from Elastic on this PR.

I'm going to be working on this module over the next few weeks, with an ultimate aim of updating the module to support the elasticsearch 7.x and simplifying the module to make it easier to use.

I'll be reviewing all the open issues and PRs over the next few days, and will merge or provide feedback where appropriate.

So please hang in there whilst we give this module some TLC.

Thanks again.

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

Dear @winnettjohnston, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs?
If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com.
You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Dear @winnettjohnston, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks